bnbarham accepted this revision. bnbarham added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:44 "case-sensitive": "false", + 'use-external-names': true, "roots": [ ---------------- Nitpick: `'` vs `"` in the rest of the file, doesn't really matter though. ================ Comment at: clang/test/Modules/submodule-in-private-mmap-vfs.m:38 +@import Foo_Private; +// expected-no-diagnostics ---------------- Nitpick: no new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131076/new/ https://reviews.llvm.org/D131076 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
