davidxl added a comment. Please also update user manual: docs/UserManual.rst
================ Comment at: test/Driver/clang_f_opts.c:90 @@ -89,3 +89,2 @@ // RUN: %clang -### -S -fprofile-instr-generate=file -fno-profile-instr-generate %s 2>&1 | FileCheck -check-prefix=CHECK-DISABLE-GEN %s -// RUN: %clang -### -S -fprofile-instr-generate=file -fno-profile-generate %s 2>&1 | FileCheck -check-prefix=CHECK-DISABLE-GEN %s // RUN: %clang -### -S -fprofile-generate=dir -fno-profile-generate %s 2>&1 | FileCheck -check-prefix=CHECK-DISABLE-GEN %s ---------------- Probably change this test into the check of disallowed option combination : -fprofile-instr-generate -fprofile-generate ================ Comment at: test/Profile/gcc-flag-compatibility.c:10 @@ -9,3 +9,3 @@ -// Check that -fprofile-generate uses the runtime default profile file. +// Check that -fprofile-generate overrides the default profraw. // RUN: %clang %s -c -S -o - -emit-llvm -fprofile-generate | FileCheck -check-prefix=PROFILE-GEN %s ---------------- Please add a FIXME here. I noticed that there is a bug in IR PGO implementation that -fprofile-generate still invokes overrider api in instrumentation which is unnecessary. Repository: rL LLVM http://reviews.llvm.org/D21823 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
