v.g.vassilev added a comment. In D130422#3689397 <https://reviews.llvm.org/D130422#3689397>, @junaire wrote:
> In D130422#3689392 <https://reviews.llvm.org/D130422#3689392>, @v.g.vassilev > wrote: > >> Thanks for working on this. This is one of the problems where is hard to >> find the right behavior. For example, if a repl running in interactive >> issues an error and then successfully recovers what's the right process >> return code success or a failure? If we decide it is a success then if we >> ran in non-interactive mode eg `clang-repl "err"` then the exit code should >> be a failure. >> >> Either way, this patch improves our current state in which we cannot detect >> failing tests in `-verify` mode. Let's accept it. > > Maybe add a FIXME in the tests? That's probably a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
