akyrtzi added a comment.

In D130710#3685436 <https://reviews.llvm.org/D130710#3685436>, @benlangmuir 
wrote:

> Is the functionality provided by `ORIGINAL_PCH_DIR` still useful for making 
> it possible to move a PCH and its referenced headers?  It's not completely 
> clear to me when this feature is used in practice.  It would be nice to 
> remove it or change the default behaviour if possible, rather than require a 
> new option, but I'm open to this approach if we think we can't change the 
> default.

Given that there was a recent change <https://reviews.llvm.org/D124946> related 
to `ORIGINAL_PCH_DIR`, I'm reluctant to change the default at this point, I 
added a `FIXME` for following up to see if we can remove it or change the 
default later on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130710/new/

https://reviews.llvm.org/D130710

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to