beanz added inline comments.
================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:142
+ if (!Inner) {
+ DiagnosticsEngine &Diags = CGM.getDiags();
+ unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error,
----------------
python3kgae wrote:
> python3kgae wrote:
> > Anastasia wrote:
> > > Is this case covered by the test?
> > Nice catch.
> > I'll add a test for this.
> Cannot add a test before other HLSL resource type like Texture2D is supported
> :(
`Texture2D` will be a `CXXRecordDecl`, not a `HLSLBufferDecl`, we only need
buffer decls for the legacy buffers. So this should be testable by nesting a
cbuffer inside a cbuffer right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130131/new/
https://reviews.llvm.org/D130131
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
