jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land.
In D130689#3684330 <https://reviews.llvm.org/D130689#3684330>, @mehdi_amini wrote: > Nice, LGTM, thanks for driving this! > >> Remember that if we want to adopt some new feature in a bigger way it should >> be discussed and added to the CodingStandard document. > > What does it mean exactly? We can't use **anything** C++17 without writing it > in the coding standards? > I'm not sure it'll be manageable: how do you see this playing out? Based on the release note, I don't think that was what was intended, although I am curious to understand what //was// intended! Looks good to me anyway (but get more buy-in, perhaps a new Discourse post too, not just an update on the existing thread, since new threads get emailed out to more people). ================ Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:20 # Map the above GCC versions to dates: https://gcc.gnu.org/develop.html#timeline +set(LIBSTDCXX_MIN 7) ---------------- This comment seems out-of-date now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
