vsapsai added a comment. In D128490#3670543 <https://reviews.llvm.org/D128490#3670543>, @ChuanqiXu wrote:
> For these indentation changes, maybe it is a good idea to edit the > `.git-blame-ignore-revs` files in the root path. That is a good idea. I'm thinking about a different option: I make my change but keep `ODRDiagsEmitter` methods over-indented to preserve the old indentation. The code is moved to a different file in D128695 <https://reviews.llvm.org/D128695> and I just format the entire file. This way the current change is easier to review (now and in git history) and the formatting is [eventually] correct. As for me, having good `git blame` is more important than having perfect formatting (proposed formatting will be still OK). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
