aaron.ballman added inline comments.
================ Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:59 + return; + auto *RD = Ty->getAsCXXRecordDecl(); + if (!RD) ---------------- ================ Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:62-66 + if (!RD->hasAttr<HLSLResourceAttr>()) + return; + + HLSLResourceAttr::ResourceClass RC = + Ty->getAsCXXRecordDecl()->getAttr<HLSLResourceAttr>()->getResourceType(); ---------------- ================ Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:78 + } + + auto &Ctx = CGM.getModule().getContext(); ---------------- Add an assertion that `ResourceMD` is always nonnull by this point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130019/new/ https://reviews.llvm.org/D130019 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
