samestep added inline comments.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:66 explicit DataflowAnalysis(ASTContext &Context) : Context(Context) {} explicit DataflowAnalysis(ASTContext &Context, bool ApplyBuiltinTransfer) : TypeErasedDataflowAnalysis(ApplyBuiltinTransfer), Context(Context) {} ---------------- sgatev wrote: > samestep wrote: > > gribozavr2 wrote: > > > Will you remove this bool overload in a later patch? > > I didn't have any plans to, but I'm fine with removing it in a later patch > > if people want to. > I think it makes sense to remove it. Can you already document that it's > deprecated in this patch? Sure, I can document that; what's the best way to do so? Is there a special way to say something is deprecated in a `///` comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130305/new/ https://reviews.llvm.org/D130305 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits