ilya-biryukov added inline comments.
================ Comment at: clang-tools-extra/clangd/AST.cpp:833 + // Check that this expands all the way until the last parameter. + auto ParamEnd = It + Parameters.size() - 1; + assert(std::distance(Args.begin(), ParamEnd) < ---------------- upsj wrote: > I think it would be safer to check this explicitly, since advancing the > iterator past its end might be UB (depending on the implementation). This could crash in `foo(1, args...)`, right? ================ Comment at: clang-tools-extra/clangd/AST.cpp:879 + // forwarded arg. + // FIXME: Maybe mark that in the AST as so, this might skip explicit calls + // too. ---------------- NIT: should fit in a single line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130260/new/ https://reviews.llvm.org/D130260 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
