owenpan added inline comments.

================
Comment at: clang/tools/clang-format/git-clang-format:539
   # filter.
-  subprocess.check_call(['git', 'diff', '--diff-filter=M', old_tree, new_tree,
-                         '--'])
+  return subprocess.call(['git', 'diff', '--diff-filter=M',
+                          old_tree, new_tree, '--exit-code', '--'])
----------------
Can we use `run()` instead of `call()` here and below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129311/new/

https://reviews.llvm.org/D129311

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to