MaskRay accepted this revision. MaskRay added inline comments.
================ Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern -fprofile-arcs \ ---------------- nickdesaulniers wrote: > MaskRay wrote: > > I feel that having 3 RUN lines is excessive. Since we already have a test > > that asan/tsan/gcov respect getModuleFlag, it is not necessary for a new > > one to duplicate all the combinations. > All three have caused problems for us; I'd prefer to retain each. Having asan/tsan may invite others to add more sanitizer tests to this not-so-related file. I can step back and think that gcov/asan are sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/ https://reviews.llvm.org/D129709 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
