jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

Wasn't there a discussion about this before, or some other patch? If so, could 
we please link such things (e.g., in the commit message) so people don't have 
to remember and find the links themselves.

FWIW, I don't think this is the right approach. For one, assuming we want such 
a logic, I would expect the default of the flag to change and not some hidden 
stuff that makes the still exposed flag meaningless.
That said, I doubt this is even what we want. Throwing away the benefits of the 
noundef for one special case. IIRC, I mentioned alternatives in the other 
discussion already,... not that I have a link handy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128907/new/

https://reviews.llvm.org/D128907

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D128907:... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Sameer Sahasrabuddhe via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... Matt Arsenault via Phabricator via cfe-commits

Reply via email to