MaskRay added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:2831 MarshallingInfoInt<FrontendOpts<"TimeTraceGranularity">, "500u">; +def ftime_trace_path : Joined<["-"], "ftime-trace=">, Group<f_Group>, + HelpText<"Turn on time profiler. Generates JSON file based on output filename. " ---------------- `ftime_trace_EQ` ================ Comment at: clang/tools/driver/cc1_main.cpp:263 + // replace the suffix to '.json' directly + SmallString<128> FileName(llvm::sys::path::filename(Path)); + SmallString<128> TracePath(Clang->getFrontendOpts().TimeTracePath); ---------------- The variable FileName can be removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
