aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some test changes, assuming that precommit CI comes back green. ================ Comment at: clang/docs/ReleaseNotes.rst:184 initializer is not allowed this is now diagnosed as an error. +- Clang now correctly emit symbols for implicitly instanciated constexpr + template function. Fixes `Issue 55560 <https://github.com/llvm/llvm-project/issues/55560>`_. ---------------- ================ Comment at: clang/test/SemaCXX/constexpr-late-instantiation.cpp:1 +// Make sure foo is instantiated and we don't get a link error +// RUN: not %clang_cc1 %s -fsyntax-only -verify ---------------- You can remove this comment since this is no longer testing the IR. ================ Comment at: clang/test/SemaCXX/constexpr-late-instantiation.cpp:2 +// Make sure foo is instantiated and we don't get a link error +// RUN: not %clang_cc1 %s -fsyntax-only -verify + ---------------- Oops, I missed that in my earlier suggestion! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
