kadircet added inline comments.

================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:499
         // Build the preamble and let the waiters know about it.
         build(std::move(*CurrentReq));
       }
----------------
regarding the flakiness, what about resetting the `Throttle` here to trigger 
the release? it's right after the build and would make sure release happens 
before the context is destroyed (+ we're not holding any locks)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129100/new/

https://reviews.llvm.org/D129100

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to