iains added a comment.

In D126694#3629094 <https://reviews.llvm.org/D126694#3629094>, @ChuanqiXu wrote:

> BTW, after I applied the patch, the compiler crashes at 
> https://github.com/ChuanqiXu9/stdmodules.

That link points to a project - is there (say) a gist of the crash information?

> I would try to add more tests about C++20 Modules.

of course, more tests can be useful, but it would be better to try to be 
specific - it does not crash for any of the tests in the clang test suite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126694/new/

https://reviews.llvm.org/D126694

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to