xbolva00 added inline comments.
================ Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 999999 main`). + ---------------- vext01 wrote: > xbolva00 wrote: > > vext01 wrote: > > > xbolva00 wrote: > > > > main is weird example here imho. > > > How comes? The docs told me to make my diffs off `main`, so that's what > > > you'd be diffing against typically. No? > > Ah, okay. I usually use it without it. > That would mean you haven't committed your changes, and `git clang-fomat` > wont work in that case, so committing is best IMHO. I use arc land :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128645/new/ https://reviews.llvm.org/D128645 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
