ckissane added a comment.

In D128667#3613222 <https://reviews.llvm.org/D128667#3613222>, @MaskRay wrote:

> `llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress` 
> doesn't work.
>
>   % /tmp/out/custom1/bin/llvm-objcopy --decompress-debug-sections clang.zstd 
> clang.zstd.uncompress
>   /tmp/out/custom1/bin/llvm-objcopy: error: 'clang.zstd': '.debug_loc': zlib 
> error: Z_DATA_ERROR
>
> Add a new test 
> `llvm/test/tools/llvm-objcopy/compress-debug-sections-zstd.test` and check 
> existing tests for zlib (SHF_COMPRESSED).
> I'll create a patch to remove .zdebug support to simplify the code.
>
> Tip: you can nullify a compression/uncompression place, then run `ninja 
> check-llvm` to find all places in llvm/ where a test may be relevant.

it seems that --decompress-debug-sections assumes always Z type compression. I 
can update the patch to fix this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128667/new/

https://reviews.llvm.org/D128667

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to