aaron.ballman added a comment.
I like the changes -- this is a much nicer syntax for specifying configuration
options!
> The only observable differences are support for the new syntax and
> -dump=config will emit using the new syntax.
Do you expect the behavior of `-dump` to cause any problems for folks using
that option from a script? I can't think of any that aren't super contrived,
but maybe you've got more thoughts there.
(Note, you should probably rebase your patch as it doesn't seem to apply
cleaning, so there's no precommit CI happening for it.)
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:85
+template <>
+void yamlize(IO &io, ClangTidyOptions::OptionMap &Options, bool,
+ EmptyContext &Ctx) {
----------------
I'm not super tickled with `IO Io` so if you want to use a more descriptive
name, feel free. Mostly just changing it for coding style conformance.
================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:113
+- .clang-tidy files can now use the more natural dictionary syntax for
specifying `CheckOptions`
+
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128337/new/
https://reviews.llvm.org/D128337
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
