sdesmalen added a comment.
Hi @sagarkulkarni19, this patch will have to wait until the ABI is implemented
so that the builtins can be decorated with the attributes. A first patch
proposing these attributes is in D127762 <https://reviews.llvm.org/D127762>.
LLVM patches that use these attributes to implement the ABI will follow soon.
We could add you as reviewer to these patches if you'd like to help us with
that?
================
Comment at: clang/include/clang/Basic/arm_sve.td:209
def IsTupleSet : FlagType<0x400000000>;
+def IsSME : FlagType<0x800000000>;
+def IsSMELoadStore : FlagType<0x1000000000>;
----------------
Is there value in having both `IsSME` and `IsSMELoadStore`?
================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:342
+ if (HasSME)
+ Builder.defineMacro("__ARM_FEATURE_SME", "1");
+
----------------
When this macro is non-zero, it suggests that the compiler implements the full
SME ACLE. That is currently not yet the case, so until then we should leave
this macro undefined.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127910/new/
https://reviews.llvm.org/D127910
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
