martong added a comment. Thanks!
What was your method to discover the unused code? Did you use an automated tool? ================ Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:66 - void dump() const; void dumpToStream(raw_ostream &os) const; ---------------- We shall not delete any `dump` or `LLVM_DUMP_METHOD` annotated function because they can be really useful in actual debugging, either in `gdb` or with other tools. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:30-33 -/// This checker documents the callback functions checkers can use to implement -/// the custom handling of the specific events during path exploration as well -/// as reporting bugs. Most of the callbacks are targeted at path-sensitive -/// checking. ---------------- As the comment says, we need this to demonstrate and document what can be the possible callbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127799/new/ https://reviews.llvm.org/D127799 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
