xazax.hun accepted this revision.
xazax.hun added a comment.
Overall looks good to me, it is a step towards having a more faithful
representation of the reality.
================
Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:978
+ assert(!Ty.isNull());
+ if (Ty.isConstQualified() && Ty->isArithmeticType()) {
// TODO: We could walk the complex types here and see if everything is
----------------
Why do we need this extra condition? I see that this was the original behavior,
just wondering if we actually know. I think there are more types than
arithmetic that can be stored in the read only memory.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127306/new/
https://reviews.llvm.org/D127306
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits