MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:684-690
CmdArgs.append(
{Args.MakeArgString(StringRef("-L") + RocmInstallation.getLibPath()),
"-rpath", Args.MakeArgString(RocmInstallation.getLibPath())});
CmdArgs.push_back("-lamdhip64");
+ CmdArgs.push_back(
+ Args.MakeArgString("-lclang_rt.builtins-" + getTriple().getArchName()));
----------------
tra wrote:
> Nit: Collapse all of these into a single `append()`
Note: I think multiple push_back isn't that bad...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127142/new/
https://reviews.llvm.org/D127142
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
