MaskRay added a comment.

In D125165#3557693 <https://reviews.llvm.org/D125165#3557693>, @jhuber6 wrote:

> In D125165#3557441 <https://reviews.llvm.org/D125165#3557441>, @MaskRay wrote:
>
>> Add openmp to `LLVM_ENABLE_PROJECTS` to trigger the issue:
>>
>>   cmake -GNinja -Sllvm -B/tmp/out/play -DCMAKE_BUILD_TYPE=Release 
>> -DLLVM_ENABLE_PROJECTS='clang;openmp' 
>> -DCMAKE_CXX_COMPILER=~/Stable/bin/clang++ 
>> -DCMAKE_C_COMPILER=~/Stable/bin/clang 
>> -DCMAKE_INSTALL_PREFIX=/tmp/install/play
>>   ninja -C /tmp/out/play install
>>
>>   clang: error: unable to execute command: Executable 
>> "clang-offload-packager" doesn't exist!
>>   clang: error: clang-offload-packager command failed with exit code 1 (use 
>> -v to see invocation)
>>   [527/5061] Building CXX object 
>> tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o
>>   ninja: build stopped: subcommand failed.
>>
>> `[Clang] Change the offload packager build to be a clang tool` does not fix 
>> the issue.
>
> This worked fine for me using a fresh build
>
>   $ cmake -G Ninja ../llvm -DCMAKE_BUILD_TYPE=Release 
> -DLLVM_ENABLE_PROJECTS='clang;openmp' -DCMAKE_CXX_COMPILER=clang++ 
> -DCMAKE_C_COMPILER=clang -DCMAKE_INSTALL_PREFIX=$HOME/clang && ninja install
>   $ ls ~/clang/bin/clang-offload-packager 
>   /home2/3n4/clang/bin/clang-offload-packager
>
> The above doesn't work for you right?

Sorry, it's not this patch's fault.
This is a problem of 
https://raw.githubusercontent.com/chromium/chromium/main/tools/clang/scripts/update.py
 . It doesn't provide `clang-offload-packager`.
Some openmp directories require the host tool `clang-offload-packager`. 
(@thakis)

I can use `-DLIBOMPTARGET_BUILD_DEVICERTL_BCLIB=off 
-DLIBOMPTARGET_BUILD_AMDGPU_PLUGIN=off -DLIBOMPTARGET_BUILD_CUDA_PLUGIN=off` to 
disable these directories.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125165/new/

https://reviews.llvm.org/D125165

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to