xazax.hun accepted this revision.
xazax.hun added a comment.

This patch looks good to me. On the other hand, I was wondering whether 
functions like this would be handled:

  pair<optional, optional> f();
  array<optional, 4> g();
  MyStructWithOptionals h();

And so on. In general, I wonder if it is a better approach to be able to plug 
the optional creation function into the general value creation function of the 
engine. So whenever the engine encounters an optional type, it could create the 
corresponding value. It could do it lazily or eagerly, however it choses. And 
the user would no longer need to match all the possible ways an optional type 
can be mentioned somewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126972/new/

https://reviews.llvm.org/D126972

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D126972: [clang... Gábor Horváth via Phabricator via cfe-commits

Reply via email to