erichkeane added a comment. This mostly/all seems reasonable to me, and the diagnostics, while not perfect, are IMO a vast improvement.
================ Comment at: clang/include/clang/Sema/DeclSpec.h:2068 case DeclaratorContext::TrailingReturnVar: + case DeclaratorContext::Association: return false; ---------------- Is this right? According to the comment, this is 'true'if the identifier is optional or required, but the mayOmitIdentifier, where you are returning 'true' says optional or not allowed? Does this make identifier 'not allowed' here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126969/new/ https://reviews.llvm.org/D126969 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits