rjmccall added a comment. Okay, I understand. So, first off, I wouldn't really call that a "weak" symbol rather than, say, a lazily-emitted symbol; "weak" already has plenty of different senses, and we should try to avoid coining more. Also, your patch description makes it sound like there's a general bug you're fixing rather than specifically an issue with re-using a single `CodeGenerator` to generate a succession of modules; please remember that people reading your commit messages don't necessarily know you or contextualize your patches by knowing that you work on Cling.
On a more technical note, it's now clear that the main thrust of your patch is the state persistence in `StartModule`. Your patch is effectively adding a feature where `StartModule` can be invoked multiple times (assuming it's been appropriately finalized from earlier invocations). I think that's fine, although I imagine it will need a lot of further changes to allow linkage between these modules. That doesn't really explain why you needed to add a new field to the CodeGenModule, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
