DanielMcIntosh-IBM created this revision. DanielMcIntosh-IBM added reviewers: MaskRay, ChuanqiXu, iains, jansvoboda11, Bigcheese, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. DanielMcIntosh-IBM requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.
The new tests in clang/test/Driver/modules.cpp added by D120540 <https://reviews.llvm.org/D120540> will fail if the toolchain getting tested doesn't support linking. This reduces the utility of the test since we would like a failure of this test to reflect a problem with modules. We should already have other tests that validate linking support. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126669 Files: clang/test/Driver/modules.cpp Index: clang/test/Driver/modules.cpp =================================================================== --- clang/test/Driver/modules.cpp +++ clang/test/Driver/modules.cpp @@ -76,11 +76,8 @@ // Check the independent use of -fcxx-modules // -// RUN: %clang -fcxx-modules -std=c++17 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX17-MODULES -// CHECK-CXX17-MODULES: "-fcxx-modules" -// RUN: %clang -fcxx-modules -std=c++14 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX14-MODULES -// CHECK-CXX14-MODULES: "-fcxx-modules" -// RUN: %clang -fcxx-modules -std=c++11 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX11-MODULES -// CHECK-CXX11-MODULES: "-fcxx-modules" -// RUN: %clang -fcxx-modules -std=c++03 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX03-MODULES -// CHECK-CXX03-MODULES: "-fcxx-modules" +// RUN: %clang -fcxx-modules -std=c++17 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// RUN: %clang -fcxx-modules -std=c++14 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// RUN: %clang -fcxx-modules -std=c++11 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// RUN: %clang -fcxx-modules -std=c++03 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// CHECK-CXX-MODULES: "-fcxx-modules"
Index: clang/test/Driver/modules.cpp =================================================================== --- clang/test/Driver/modules.cpp +++ clang/test/Driver/modules.cpp @@ -76,11 +76,8 @@ // Check the independent use of -fcxx-modules // -// RUN: %clang -fcxx-modules -std=c++17 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX17-MODULES -// CHECK-CXX17-MODULES: "-fcxx-modules" -// RUN: %clang -fcxx-modules -std=c++14 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX14-MODULES -// CHECK-CXX14-MODULES: "-fcxx-modules" -// RUN: %clang -fcxx-modules -std=c++11 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX11-MODULES -// CHECK-CXX11-MODULES: "-fcxx-modules" -// RUN: %clang -fcxx-modules -std=c++03 -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX03-MODULES -// CHECK-CXX03-MODULES: "-fcxx-modules" +// RUN: %clang -fcxx-modules -std=c++17 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// RUN: %clang -fcxx-modules -std=c++14 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// RUN: %clang -fcxx-modules -std=c++11 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// RUN: %clang -fcxx-modules -std=c++03 -### -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// CHECK-CXX-MODULES: "-fcxx-modules"
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
