v.g.vassilev added reviewers: rsmith, lhames, dblaikie, sgraenitz. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. Herald added a subscriber: StephenFan.
@Purva-Chaudhari, this looks reasonable to me. I am adding more reviewers to discuss the way we refer other tests from `clang-repl`. ================ Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify ---------------- @rsmith, would it be acceptable to have a test that refers other tests from the repo in that manner? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125946/new/ https://reviews.llvm.org/D125946 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
