mantognini added a comment. In D126197#3533674 <https://reviews.llvm.org/D126197#3533674>, @steakhal wrote:
> I'm not using this script file, so I'm not gonna be too picky about this. > However, I would be more confident landing changes if we had tests exercising > the changed behavior. > If you plan to land more changes to this file, consider adding some tests. I agree tests would be good, but I'm not sure where to start. To clarify, that is also the only change I've got to this file and I don't plan further change in the near future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126197/new/ https://reviews.llvm.org/D126197 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
