jhuber6 added a comment. In D126226#3532423 <https://reviews.llvm.org/D126226#3532423>, @tra wrote:
> We keep running into the same old underlying issue that we do not have a good > way to name/reference specific parts of the compilation pipeline. -Xfoo used > to work OK for the linear 'standard' compilation pipeline, but these days > when compilation grew from a simple linear pipe it's no longer adequate and > we need to extend it. Yeah, it's getting increasingly complicated to refer to certain portions of the compilation toolchain as we start adding more complicated stuff. Just recently I had a problem that I wanted to pass an `-Xclang` argument only to the CUDA toolchain, and there's no way to do it as far as I can tell. It may be worth revisiting this whole concept to support more arbitrary combinations. > Speaking of triples. I think using triple as the selector is insufficient for > general offloading use. We may have offload variants that would use the same > triple, but would be compiled using their own pipeline. E.g. the GPU binaries > for sm_60 and sm_80 GPUs will use the same nvptx64 triple, but would > presumably be lined with different linker instances and may need different > options. My understanding is that AMDGPU has even more detailed offload > variants (same triple, same GPU arch, different features). I don't know > whether it's applicable to OpenMP, though. I think it is. IIRC OpenMP has a > way to specialize offload to particular GPU variant and that would probably > give you multiple offload targets, all with the same triple. Yes, it's not a truly generic solution. But I figured that just being able to specify it for each "tool-chain" was sufficient for the use-case here and we can expand it as needed. I added support for OpenMP to use `--offload-arch` recently so we definitely use it. The OpenMP offloading GPU runtime library is now built as a static library with `--offload-arch=` for all 32 supported architectures currently, it works surprisingly well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126226/new/ https://reviews.llvm.org/D126226 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
