erichkeane added a comment.

How much of P0848 is missing after this?  If nothing/not much, should we update 
cxx_status.html as well?



================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2330
+  /// To achieve that, we remove all non-selected destructors from the AST,
+  /// which is a bit unusual. We can't let those declarations be in AST and 
rely
+  /// on LookupSpecialMember to return the correct declaration because a lot of
----------------
I don't think this ends up being acceptable (removing them from the AST).  
Instead, we should probably mark them as "invalid" and update getDestructor to 
only return the 'only' destructor, or the first not-invalid one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126194/new/

https://reviews.llvm.org/D126194

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to