steakhal added inline comments.

================
Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:233
+      : Kind(k), Ctx(ctx), Parent(parent), ID(ID) {
+    assert(Ctx);
+  }
----------------
martong wrote:
> To be consistent with the other hunks, where you assert on the parameter, not 
> on the member.
It's totally messed up, there is absolutely no consistency regarding this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126198/new/

https://reviews.llvm.org/D126198

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to