dexonsmith added inline comments.
================
Comment at: clang/unittests/Lex/DependencyDirectivesScannerTest.cpp:175
"#define MACRO con tent ", Out));
- EXPECT_STREQ("#define MACRO con tent\n", Out.data());
+ EXPECT_STREQ("#define MACRO con tent\n", Out.data());
----------------
Can you clarify why this is changing in this patch? It’s not obvious to me why
this would start optimizing internal whitespace of macros.
(I also can’t remember if it’s safe/correct. Is there a way to stringify the
contents of a macro? If so, this would change the result… if not, then this
seems like an improvement, but maybe better for a separate patch?)
(If there’s a good reason to change it here, don’t want to hold it up, but it’s
not explained in the commit message so it’s not obvious to me.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125487/new/
https://reviews.llvm.org/D125487
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
