khchen added a comment.
please move those tests to `test/CodeGen/RISCV/rvv-intrinsics` and rename them
without `rvv-` prefix.
================
Comment at: clang/include/clang/Basic/riscv_vector.td:1511
+__extension__ extern __inline
+__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
+unsigned long vread_csr(enum RVV_CSR csr) {
----------------
pcwang-thead wrote:
> craig.topper wrote:
> > Do we need __gnu_inline__ and __artificial__? The only intrinsics headers
> > that have them in clang are in ppc_wrappers. X86 uses
> > `__attribute__((__always_inline__, __nodebug__`
> I just made it the same as GCC.
Why do you think making it same as GCC is better than same as other targets in
clang?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125875/new/
https://reviews.llvm.org/D125875
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
