nickdesaulniers added inline comments.
================ Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify -S %s -o %t + ---------------- nickdesaulniers wrote: > nickdesaulniers wrote: > > Consider adding a test: > > > > ``` > > // RUN: %clang_cc1 -fsyntax-only -verify %s -x assembler-with-cpp < %s > > ``` > > > > I don't think you need `-S` here or `-o %t` since there should be nothing > > produced from -fsyntax-only. > Sorry, I missed a `-` for "read from stdin": > ``` > // RUN: %clang_cc1 -fsyntax-only -verify %s -x assembler-with-cpp - < %s > ``` Sorry, I meant for you to have two run lines. One that specified `-x assembler-with-cpp` and one without. But I think `-x assembler-with-cpp` is not necessary, you should/can/may drop it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
