dexonsmith accepted this revision.
dexonsmith added a comment.
LGTM, thanks! One comment online below.
================
Comment at: clang/include/clang/Config/config.h.cmake:19
#cmakedefine CLANG_DEFAULT_STD_C LangStandard::lang_${CLANG_DEFAULT_STD_C}
+// Always #define something so that missing the config.h #include at use sites
+// becomes a compile error.
----------------
I just noticed that the other comments in this file are C-style. Probably the
new ones should be too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124974/new/
https://reviews.llvm.org/D124974
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
