aprantl added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.h:536
+ /// Create and attach debuginfo to a the provided string literal GV.
+ void AddStringLiteralDebugInfo(llvm::GlobalVariable *GV, StringRef Name,
----------------
I would appreciate a comment explaining the motivation behind doing this here.
================
Comment at: clang/test/CodeGen/debug-info-variables.c:6
+
+// CHECK: DIGlobalVariable({{.*}}line: [[@LINE+2]]
+const char* s() {
----------------
would be nice to also check the the type is char*, etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123534/new/
https://reviews.llvm.org/D123534
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
