pratlucas marked an inline comment as done.
pratlucas added inline comments.
================
Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:242
+ // Find last push instruction for GPRCS2 - spilling of high registers
+ // (r8-r11) could consist of multiple tPUSH and tMOVr instructions.
+ while (true) {
----------------
efriedma wrote:
> It seems sort of fragile to assume the entry block doesn't contain any tPUSH
> instructions; we can use them in places other than the prologue. Can we use
> the FrameSetup flag?
This approach is fragile indeed, I guess the fact that high reg spills are less
usual has helpep it go unnoticed for so long.
I've added the checks for the FrameSetup flag to make sure it doesn't run over
into unrelated instructions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125094/new/
https://reviews.llvm.org/D125094
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
