pcc added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1843 + + auto *FTRTTIProxy = new llvm::GlobalVariable( + TheModule, Addr->getType(), ---------------- ychen wrote: > pcc wrote: > > Are these proxy variables necessary? I think that now that we have custom > > code generation for this you should be able to use a GOTPCREL relocation to > > refer to the global. > I attempted the GOTPCREL approach in a local branch. It didn't work for a > reason that I couldn't remember off the top of my head. I'll find out. > > > I think that now that we have custom code generation for this > > Sorry, I don't quite follow which `custom code generation` you are referring > to. Do you mean the changes in `AsmPrinter.cpp`? > Sorry, I don't quite follow which custom code generation you are referring > to. Do you mean the changes in AsmPrinter.cpp? Yes, that's what I meant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
