jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land.
LGTM! Thanks for splitting this out. ================ Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:120 + clEnumValN(ScanningMode::DependencyDirectivesScan, + "preprocess-directives-scan", + "The set of dependencies is computed by preprocessing with " ---------------- Probably unnecessary bike-shedding, but something like `preprocess-dependency-directives` or `scan-and-preprocess-dependency-directives` would read better IMO. Up to you whether you change this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125484/new/ https://reviews.llvm.org/D125484 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
