jdoerfert requested changes to this revision.
jdoerfert added a comment.

In D125378#3506001 <https://reviews.llvm.org/D125378#3506001>, @nikic wrote:

> Please specify the semantics of the new LLVM attribute in LangRef -- though I 
> don't really understand why you need an LLVM-side attribute at all.

+1. I doubt this patch is helpful.

> Shuffle attribute has been added as per suggestions/comments from review: 
> D124158 <https://reviews.llvm.org/D124158>

I failed to see where this was suggested.

---

My suggestion was and still is summarized in: 
https://reviews.llvm.org/D124158#3486110


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125378/new/

https://reviews.llvm.org/D125378

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D125378:... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Nikita Popov via Phabricator via cfe-commits
    • [PATCH] D12... Christudasan Devadasan via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... Nicolai Hähnle via Phabricator via cfe-commits
    • [PATCH] D12... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits

Reply via email to