ken-matsui added inline comments.
================ Comment at: clang/test/Preprocessor/line-directive-system-headers.c:2-6 -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:92:2: error: ABC' -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'blonk.c:93:2: error: DEF' -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'line-directive.c:11:2: error: MAIN7' -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'enter-1:118:2: error: ENTER1' -// RUN: not %clang_cc1 -E %s 2>&1 | grep 'main:121:2: error: MAIN2' ---------------- aaron.ballman wrote: > ken-matsui wrote: > > aaron.ballman wrote: > > > I think we're losing a bunch of test coverage from this. Why did you drop > > > these? > > These are also tested on `line-directive.c` and possibly redundant, so I > > removed them. > > Should I keep them? > You're right, those are redundant; I'm fine removing them here. I see :+1: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
