curdeius requested changes to this revision.
curdeius added a comment.
This revision now requires changes to proceed.
Thanks for working on this!
Is there a bug report somewhere? If not, may you create one please?
================
Comment at: clang/lib/Format/WhitespaceManager.cpp:398
+ Changes[i].Tok->is(tok::l_brace) &&
+ Changes[i].Tok->is(BK_BracedInit)) {
+ return true;
----------------
Elide braces please.
================
Comment at: clang/unittests/Format/FormatTest.cpp:17321
+
+ verifyFormat(Expected, ToFormat, Alignment);
+ }
----------------
I don't think you need to create variables, just online the strings.
Also, could you minimize (and possibly split) as much as possible these test
cases?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125162/new/
https://reviews.llvm.org/D125162
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
