curdeius marked 5 inline comments as done. curdeius added inline comments.
================ Comment at: clang/unittests/Format/FormatTest.cpp:23545 + // Newlines are important here. + EXPECT_EQ("FOO(1+2 );\n", format("FOO(1+2 );\n", Style)); + EXPECT_EQ("FOO(1+2 )\n", format("FOO(1+2 )\n", Style)); ---------------- curdeius wrote: > owenpan wrote: > > Do we really need this test case? > Not really. I just wrote it to cover both cases but it's covered by existing > cases indeed. Will remove. On a second thought, we don't have any other test with a semicolon and a newline, so I'd rather keep this test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123676/new/ https://reviews.llvm.org/D123676 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits