zixuw added a comment.

In D124964#3492423 <https://reviews.llvm.org/D124964#3492423>, @dang wrote:

> LGTM! If I understand the issue correctly we gave `llvm::Regex::match` a 
> string temporary to match against before and now we store it for long enough 
> to process the match results?

Yup, exactly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124964/new/

https://reviews.llvm.org/D124964

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to