rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm, thanks! In D124666#3490871 <https://reviews.llvm.org/D124666#3490871>, @frederic-tingaud-sonarsource wrote: > By the way, in the current state of the code, there is no risk of such > conflict between typo correction and UnqualifiedBase, because when an > unqualified base exists the lookup result will not be empty. > That's why the test was not failing even without moving the compatibility > first. Yep, that's exactly it, but with the reordering it's somewhat clearer that, if we make this work for MS compat purposes, typo correction will not occur. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124666/new/ https://reviews.llvm.org/D124666 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
