steplong added inline comments.
================
Comment at: clang/lib/Parse/ParsePragma.cpp:3561
<< "intrinsic";
return;
}
----------------
hans wrote:
> since the above is just a warning, we should probably still call the ActOn..
> method?
Hmm, I'm not sure because all the msgs above are also warnings (diag::warn_)
================
Comment at: clang/lib/Sema/SemaAttr.cpp:1079
+ MSFunctionNoBuiltins.insert(MSFunctionNoBuiltins.end(),
+ NoBuiltins.begin(), NoBuiltins.end());
+}
----------------
hans wrote:
> Do we want to avoid duplicates in MSFunctionNoBuiltins? Or maybe it doesn't
> matter?
Yea, I didn't think it really mattered. I originally wanted to use a set, but I
needed the strings to be stored in contiguous memory for
NoBuitinAttr::CreateImplicit() in Sema::AddRangeBasedNoBuiltin()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124702/new/
https://reviews.llvm.org/D124702
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
