rovka added inline comments.
================ Comment at: flang/test/Driver/fno-integrated-as.f90:6 +!-------------------------- +! Verify that there _is_ a seperate line with an assembler invocation +! RUN: %flang -c -fno-integrated-as %s -### 2>&1 | FileCheck %s ---------------- ================ Comment at: flang/test/Driver/fno-integrated-as.f90:10 +! CHECK-SAME: "-o" "[[assembly_file:.*]].s" +! CHECK-NEXT: "-o" "fno-integrated-as.o" "[[assembly_file:.*]].s" + ---------------- ================ Comment at: flang/test/Driver/fno-integrated-as.f90:18 +! DEFAULT-LABEL: "-fc1" +! DEFAULT-SAME: "-o" "fno-integrated-as.o" "{{.*}}fno-integrated-as.f90" ---------------- Nit (here and above): Is it a rule that `-o blah` comes right before the input file, or should we also add a {{.*}} in between in case other flags sneak in? ================ Comment at: flang/test/Driver/save-temps.f90:1 +! Tests for the `-save-temps` flag. As `flang` does not implement `-fc1as` (i.e. a driver for the intergrated assembly), we need to +! use `-fno-integrated-as` here. ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits